OUT-4032: update default client home copy - #233
Merged
Conversation
Replace the example default Client Home body with the approved "How we'll work together" copy, and set the greeting subheading default to the approved brand-personalized line via a shared defaultSubheading constant. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace the hardcoded legacy subheading literal with the shared defaultSubheading constant so the seed never drifts from the schema default. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe PR updates the default Client Home body, greeting subheading, and default banner path for newly created settings while adding the corresponding database-default migration.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Create default settings] --> B[Shared default subheading]
A --> C[New default body copy]
A --> D[Default banner media lookup]
B --> E[Settings schema default]
B --> F[Legacy data migration seed]
G[Render Client Home] --> H{Classified as untouched default?}
H -->|Yes| I[Hide action-items card]
H -->|No| J[Render action-items card]
Reviews (2): Last reviewed commit: "feat(OUT-4032): update default client ho..." | Re-trigger Greptile |
Gate the "Your actions" card on all three render sites (IU editor, IU preview, CU client) behind isDefaultClientHome — hide it while the body still matches the seed copy or the settings row was never saved. The never-saved (createdAt === updatedAt) check is robust to editor normalization and legacy rows with older default copy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Point the default banner to common/Container_14.png. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
@greptileai review PR again |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: OUT-4032
Changes
defaultContent) with the approved "How we'll work together" copy — three sections (🏠 home base, 🔔 we'll keep you posted, 💬 just message us). Removed the old example callout, duplicateWelcomeH1, working-hours table and portal sections.Everything you need to work with {{workspace.brand}}, all in one place.(theheadingdefault already matchedWelcome, {{client.firstName}}, so it was left unchanged).defaultSubheadingconstant (@settings/constants) consumed by both the schema column default and the data-migration seed so the two can't drift.20260810044541_update-default-client-home-subheading(ALTER COLUMN "subheading" SET DEFAULT ...).Testing Criteria
pnpm typecheck— passes.pnpm lint— passes, 0 warnings.pnpm drizzle-kit generatereports "No schema changes" after the constant refactor, confirming the generated migration matches the schema.Notes
pnpm drizzle-kit migrate). It only changes the column default — existing rows keep their content.Impact & Surface Area of Change
SettingsActionsService.getForWorkspace→createOne, which omitssubheading/content-defaults). Existing client homes are untouched.defaultContent/defaultSubheadingare also referenced byscripts/data-migration/settings.ts(legacy import tool) — now uses the shared constant.MinimalEditorand the new value is correctly wrapped in a single<p>block (matches the editor's single-block document model).