fix(OUT-4019): guard against stale table selection on drop

[priosshrsth]

Dropping content while a table cell selection is active threw RangeError: Selection passed to setSelection must point at the current document. OUT-4019 · Sentry

Root cause is upstream: prosemirror-tables' tableEditing plugin returns the current view.state.selection from its createSelectionBetween prop whenever a cell selection is active. ProseMirror's drop handler calls that prop after it has already modified the doc, then passes the stale selection to tr.setSelection — which throws. The DOM-change reader (readDOMChange) has the same shape, so this isn't drop-only, just rarer.

What to look at

• Table.ext/table-stale-selection-guard.ts — the guard returns null when $anchor.doc === view.state.doc, which makes someProp fall through to the table plugin and leaves normal cell-selection dragging untouched. It only returns a selection when the docs differ. Confirm that read of someProp's first-non-null semantics.
• priority: 1000 — required so this plugin is consulted before tableEditing. Worth a second pair of eyes given Tiptap reverses the extension list before sorting by priority.

Verified / not verified

Verified: pnpm typecheck and pnpm lint pass.

Not verified: no automated test. Vitest here runs environment: 'node' with no jsdom, and the two things that could actually break — plugin ordering and the ProseMirror prop contract — need a real editor to exercise. Manual repro is the check: select cells in a table, drag content, drop into the selected cell.

Regression surface is table editing generally — cell selection via mouse drag, drag-and-drop in and out of tables, and IME/composition input inside cells.

[linear-code]

OUT-4019

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
client-home-v3	Ready	Preview	Aug 11, 2026 5:13am

[greptile-apps]

Greptile Summary

The PR adds a high-priority ProseMirror plugin that prevents the table editing plugin from returning a selection tied to the pre-change document.

• Defers to normal table selection handling when the callback positions belong to the current view document.
• Returns a text selection resolved against the modified document when drop or DOM-change processing creates a document mismatch.
• Registers the guard before the table editing plugin through Tiptap extension priority.

Confidence Score: 5/5

The PR appears safe to merge; no concrete blocking or independently actionable non-blocking issues were identified.

The guard precedes the table editing plugin, defers under normal current-document selection handling, and intercepts the documented stale-document path with a selection resolved against the callback document.

Important Files Changed

Filename	Overview
src/features/editor/components/Editor/extensions/Table.ext/index.ts	Registers the stale-selection guard in the table extension bundle; its explicit priority gives it the intended effective plugin order.
src/features/editor/components/Editor/extensions/Table.ext/table-stale-selection-guard.ts	Adds a narrowly scoped createSelectionBetween override that intercepts stale-document callbacks while preserving normal cell-selection behavior.

_{Reviews (1): Last reviewed commit: "fix(OUT-4019): guard against stale table..." | Re-trigger Greptile}