fix(POR-22645): reject nil UUID user lookups before Copilot API calls - #1411
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(POR-22645): reject nil UUID user lookups before Copilot API calls#1411cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Guard getInternalUser/getClient against the nil UUID (00000000-0000-0000-0000-000000000000) so tasks-app returns a controlled APIError instead of surfacing Copilot platform 'not able to get user record' errors to Sentry. Also reject nil UUID ids in auth tokens. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
isNilUuidhelper for the nil UUID (00000000-0000-0000-0000-000000000000)CopilotAPI#getInternalUserand#getClientto fail fast withAPIErrorinstead of calling Copilot with an invalid idinternalUserId/clientIdas unauthenticated inauthenticatenullfromCopilotAPI#mewhen the token user id is the nil UUIDTesting Criteria
yarn test src/utils/uuid.test.ts src/utils/CopilotAPI.nil-uuid.test.ts— 5 tests passAPIErrorand do not invoke Copilot SDKretrieveInternalUser/retrieveClientNotes
not able to get user record: code [parameter_invalid] error [no user found with id: 00000000-0000-0000-0000-000000000000]in Tasks Sentry.createdById/initiatorId= nil UUID if errors persist.Impact & Surface Area of Change
src/utils/CopilotAPI.ts— all internal-user and client lookupssrc/app/api/core/utils/authenticate.ts— request auth boundary