fix(POR-22647): handle platform unknown user type errors in notification-center - #1413
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(POR-22647): handle platform unknown user type errors in notification-center#1413cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…ion-center Gracefully catch platform API failures when loading in-product notifications via /notification-center instead of letting them bubble up as unhandled Next.js request errors in Sentry. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centerso platform API failures (e.g.unknown user type) show a user-friendlySilentErrorinstead of an unhandled Next.js request error in SentrynotificationIdsafeParsefor in-product CTA params and show a clear message when the notification is not task-linkedTesting Criteria
yarn lint:checkpasses on the changed fileNotes
unknown user typeerror originates from the Assembly platform notification API, not tasks-app code. This PR prevents it from surfacing as a Sentry production alert when an IU opens a malformed or incompatible in-product notification.Impact & Surface Area of Change
/notification-centerpage only — error handling for notification deep-link redirects