fix(POR-22649): handle app-setup entity errors in notification-center - #1415
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(POR-22649): handle app-setup entity errors in notification-center#1415cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add defensive error handling on /notification-center so platform API failures (e.g. "No entity type for app-setup found") show a user-friendly SilentError instead of an unhandled Next.js request error in Sentry. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centerso platform API failures (e.g.No entity type for app-setup found) show a user-friendlySilentErrorinstead of an unhandled Next.js request error in SentrynotificationIdsafeParsefor in-product CTA params and show a clear message when the notification is not task-linkedTesting Criteria
yarn lint:checkpasses on the changed fileNotes
No entity type for app-setup founderror originates from the Assembly platform notification service when an IU opens an in-product notification whose entity type isapp-setup(app installation/setup notifications). Tasks app only handles task-linked notifications; this PR prevents the platform error from surfacing as a Sentry production alert.app-setup).Impact & Surface Area of Change
/notification-centerpage only — error handling for notification deep-link redirects