fix(POR-22653): handle platform module-not-found errors gracefully - #1420
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(POR-22653): handle platform module-not-found errors gracefully#1420cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Wrap notification-center and configure-tasks-app server loads in try/catch so platform errors (e.g. Module not found / parameter_invalid_empty) render SilentError instead of unhandled Next.js request errors in Sentry. Also harden CopilotAPI#getNotificationSettings to return empty settings when app install listing or settings fetch fails. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centernotification fetch in try/catch so platform errors (e.g.Module not found/parameter_invalid_empty) render a user-friendlySilentErrorinstead of an unhandled Next.js request error in Sentry/configure-tasks-appwith token validation and try/catch around page data fetchesCopilotAPI#getNotificationSettingsto return empty settings when app install listing or settings fetch failsnotificationIdsafeParsefor in-product CTA params and show a clear message when the notification is not task-linkedTesting Criteria
/notification-centerand/configure-tasks-apperror paths: invalid token, missing notificationId, API failure, non-task CTA paramsresolveNotificationSettingIdunit tests pass (7/7)Notes
code [parameter_invalid_empty] error [Module not found]). This PR reduces Sentry noise and improves UX; platform/app-install configuration may still need manual follow-up.Impact & Surface Area of Change
src/app/notification-center/page.tsx— IU notification deep-link entry pointsrc/app/configure-tasks-app/page.tsx— IU app configuration entry pointsrc/utils/CopilotAPI.ts— notification settings resolution for IU email gating