fix(POR-22655): handle platform ContractTemplate.fields unmarshaling errors in notification-center - #1421
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
…errors in notification-center Wrap notification fetch in try/catch so platform Go unmarshaling errors (ContractTemplate.fields object vs array mismatch) surface as SilentError instead of unhandled request errors in Sentry. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centernotification fetch in try/catch so platform Go unmarshaling errors (ContractTemplate.fieldsobject vs[]contracts.ContractFieldarray mismatch) surface as a user-facingSilentErrorinstead of an unhandled request error in the Tasks Sentry project.nullearly when token payload lacksnotificationIdinstead of throwing.safeParsefor CTA params so non-task notifications fail gracefully.Testing Criteria
yarn lint:check src/app/notification-center/page.tsxpasses (no new errors)Notes
ContractTemplaterecord hasfieldsstored as a JSON object but the Go backend expects[]contracts.ContractField.Impact & Surface Area of Change
/notification-centerroute only — IU in-product notification deep-link redirect flow.