fix(POR-22658): handle platform PaymentLink validation errors in notification-center - #1425
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(POR-22658): handle platform PaymentLink validation errors in notification-center#1425cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…fication-center Wrap notification fetch in try/catch so platform API errors (e.g. PaymentLink.Currency required validation) show a user-friendly SilentError instead of an unhandled request error in Sentry. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centernotification fetch in try/catch so platform API errors (e.g.PaymentLink.Currencyrequired validation) show a user-friendlySilentErrorinstead of an unhandled request error in SentrynotificationIdsafeParsefor CTA params with a friendly message when the notification is not task-linkedTesting Criteria
Notes
unhandled request error: Key: 'PaymentLink.Currency' Error:Field validation for 'Currency' failed on the 'required' tagPaymentLinkis missing a requiredCurrency; not from tasks-app code/notification-center)Impact & Surface Area of Change
/notification-centerserver component only — IU notification deep-link entry point