fix(POR-22663): handle platform contract file authorization errors in notification-center - #1426
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
… notification-center When an IU opens an in-product notification via /notification-center, the platform may fail with unauthorized_action when fetching an associated contract file. Catch platform errors and show SilentError instead of surfacing an unhandled request error to Sentry. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centerwhen the platform fails to fetch an associated contract file (unauthorized_action/unable to perform action)notificationIdsafeParsefor CTA params instead of throwing on invalid notification shapeTesting Criteria
Notes
not able to get contract file: code [unauthorized_action] error [unable to perform action]when loading notification details that reference a contract file the IU cannot access.Impact & Surface Area of Change
/notification-centerserver component only — IU in-product notification deep-link entry point.