fix(POR-22669): handle platform channelID file metadata errors in notification-center - #1432
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(POR-22669): handle platform channelID file metadata errors in notification-center#1432cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…ification-center Wrap notification fetch in try/catch so platform API errors like 'no channelID to assign file metadata' show a user-friendly SilentError instead of an unhandled request error in Sentry. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centerfor platform Files API errors (e.g.no channelID to assign file metadata)getNotificationDetailin try/catch and return a user-friendlySilentErrorinstead of an unhandled request errorsafeParsefor CTA params validationTesting Criteria
/notification-centerentry pointNotes
no channelID to assign file metadataoriginates from the Assembly platform Files API, not tasks-app source code. It surfaces in the Tasks Sentry project when an IU opens an in-product notification via/notification-centerand the platform fails while resolving file metadata without a channel ID.Impact & Surface Area of Change
/notification-centerpage behavior when loading IU notificationsSilentError