Add toasts, offcanvas, scrollspy, icons, icon links, focus ring, plac… - #19
Closed
pdebruic wants to merge 2 commits into
Closed
Add toasts, offcanvas, scrollspy, icons, icon links, focus ring, plac…#19pdebruic wants to merge 2 commits into
pdebruic wants to merge 2 commits into
Conversation
…eholders, dark mode toggles, aspect ratio. Update css and js libs to 5.3.8. Add convenience method to both delete and add the large CSS and JS files to the image.
Contributor
Author
|
Will try again now. |
Contributor
Author
|
I copy/pasted all the new code into a new image and its still reformatting the symbols in the metadata in the tonel files in this repo to strings so winds up with a few thousand changed files. |
Owner
|
@pdebruic the other one was merged. This one has conflicts |
Contributor
Author
|
Yep I'll close this one and re-do it under the new formatting regime....
… On Jun 30, 2026, at 4:42 PM, Astares ***@***.***> wrote:
astares left a comment (astares/Seaside-Bootstrap5#19)
@pdebruic the other one was merged. This one has conflicts
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eholders, dark mode toggles, aspect ratio.
Update css and js libs to 5.3.8. Add convenience method to both delete and add the large CSS and JS files to the image.
Iceberg or git still reformatting strings to symbols or the other way around so there's a lot of changes here that don't do anything. Not sure how to prevent that.