Skip to content

updated BS5 libraries to 5.3.8, rectified an example and added some methods - #22

Merged
astares merged 3 commits into
astares:masterfrom
sanjayminni:master
Aug 25, 2026
Merged

updated BS5 libraries to 5.3.8, rectified an example and added some methods#22
astares merged 3 commits into
astares:masterfrom
sanjayminni:master

Conversation

@sanjayminni

Copy link
Copy Markdown
Contributor

No description provided.

sanjayminni and others added 3 commits August 21, 2026 15:38
example Input Group rectified - required probably due to change in BS library
SBSLinkButtonTag - dataTarget ,  dataToggle
SBSModalTag - dataBackdrop
@sanjayminni

Copy link
Copy Markdown
Contributor Author

BS5 all libraries upgraded to 5.3.8, maybe in future we can upload the Deployment and Development libraries optionally since they are heavy and only the CDN in the default baseline.

input group example has been rectified prepend / append tags removed (i think that was caused due to a change in the library)

3 tags-methods added

pharo64-8.0 removed from build matrix as it was failing

is something like pharo64-13 to be added ?

@astares
astares merged commit 57363cc into astares:master Aug 25, 2026
4 checks passed
@astares

astares commented Aug 25, 2026

Copy link
Copy Markdown
Owner

@pdebruic / @sanjayminni

I merged this PR as it had no merge conflict and updates the libs to 5.3.8
And yes - I guess we can add Pharo 13 if Seaside is loaded there cleanly.

Nonetheless it would be good to reclaim other usefull stuff from @pdebruic from his PR
#21 now

@astares

astares commented Aug 25, 2026

Copy link
Copy Markdown
Owner

@sanjayminni
Can you please also provide additionally another new PR with tests for

  • SBSModalTag >> dataBackdrop:
  • SBSLinkButtonTag >> dataToggle:
  • SBSLinkButtonTag >> dataTarget:

so we have anything tested. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants