Skip to content

feat add oracle price feed integration tests#510

Open
Obiajulu-gif wants to merge 1 commit into
astera-hq:mainfrom
Obiajulu-gif:feat/418-oracle-price-feed-tests
Open

feat add oracle price feed integration tests#510
Obiajulu-gif wants to merge 1 commit into
astera-hq:mainfrom
Obiajulu-gif:feat/418-oracle-price-feed-tests

Conversation

@Obiajulu-gif
Copy link
Copy Markdown
Contributor

Summary

Related Issue

Closes #

Type of Change

  • Bug fix
  • New feature
  • Refactor / internal improvement
  • Documentation update
  • Test-only change
  • DevOps / CI change

Changes

Testing Performed

Smart Contract Security Checklist

  • CEI pattern followed (checks before effects before interactions)
  • All arithmetic uses checked operations (checked_add, checked_sub, saturating_*) — no bare + or * without overflow guard
  • New state-changing functions have reentrancy guard (non_reentrant_start / non_reentrant_end)
  • New admin functions emit events
  • No panic!() with string messages — typed errors (PoolError, InvoiceError) used instead
  • Storage TTL extended in all functions that touch persistent state
  • Fuzz test added or updated for new invariants

Checklist

  • Tests added or updated (cargo test / npm test passes)
  • Documentation updated (README, inline docs, API reference)
  • For security or incident-response changes, at least one core team approval is noted in this PR
  • cargo fmt and cargo clippy -- -D warnings pass (if contracts changed)
  • npm run lint and npm run build pass (if frontend changed)
  • No secrets, private keys, or production contract IDs in code
  • API reference updated if contract interface changed
  • PR title is descriptive and follows type(scope): description convention
  • Smart contract security checklist above completed (if contracts/ changed)

Screenshots (UI changes only)

Closes #418

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 28, 2026

@Obiajulu-gif Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add oracle price feed verification integration test

1 participant