fix: use ceiling division in calculate_factoring_fee to prevent truncation to zero#525
Merged
sanmipaul merged 1 commit intoMay 28, 2026
Conversation
…ation to zero Integer division truncates toward zero, so when principal × fee_bps < BPS_DENOM (10_000), the fee silently rounds to 0 regardless of the configured rate. This affects small invoices: e.g. 50 stroops at 1% (100 bps) → fee = 0. Replace truncating division with ceiling division: fee = (numerator + BPS_DENOM - 1) / BPS_DENOM This guarantees any non-zero fee rate on any non-zero principal yields at least 1 stroop. No behaviour change for normal-sized invoices (the +9999 is washed out by integer division).
|
@Junman140 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #355
Integer division truncates toward zero, so when principal × fee_bps < BPS_DENOM
(10_000), the fee silently rounds to 0 regardless of the configured rate.
This affects small invoices: e.g. 50 stroops at 1% (100 bps) → fee = 0.
Replace truncating division with ceiling division:
fee = (numerator + BPS_DENOM - 1) / BPS_DENOM
This guarantees any non-zero fee rate on any non-zero principal yields
at least 1 stroop. No behaviour change for normal-sized invoices
(the +9999 is washed out by integer division).