fix: resolve CEI violations and remove state mutation from invoice read flow#528
Merged
Conversation
|
@0xMegie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #318 - Reordered
deposit()to follow strict CEI (Checks-Effects-Interactions) flow by performing share minting and state updates before external stablecoin transfers. Added regression tests to ensure failed share mint operations do not transfer investor funds.closes #319 - Updated
withdraw()execution order to ensure storage updates, share burns, and accounting changes occur before outgoing token transfers. Added tests validating investor state remains unchanged if transfer execution fails.closes #320 - Refactored
fund_invoice()/init_funding_request()to persistFundedInvoicerecords and update pool accounting before transferring USDC to SMEs. Added coverage for transfer failure rollback scenarios.closes #322 - Removed state mutation side effects from
get_invoice()by extracting expiration handling into explicit expiration logic flow.get_invoice()is now a pure read operation with no storage writes or state transitions.