Pinning a model version becomes visible, and Grok Build joins as a third agent - #191
Open
astetic-dev wants to merge 1 commit into
Open
Pinning a model version becomes visible, and Grok Build joins as a third agent#191astetic-dev wants to merge 1 commit into
astetic-dev wants to merge 1 commit into
Conversation
…ird agent Refs #190. Pinning to an exact model version already worked -- the model field is free text and `claude --model` takes a full model name -- but the suggestion list only ever offered aliases, so you had to know it was possible and how the name was spelled. Those names now come from models.json in the config folder: a separate file, because #92 removed a list in the source for the good reason that it goes stale on every model release. Adding a model costs no rebuild, counts during a running session, and whatever you type yourself is appended after a successful start. Antigravity turned out to be broken. `agy models` has been printing two tab-separated columns instead of a bare slug for some time, and the whole line went to the CLI as the --model value. Agy accepts an unknown model without an error and quietly falls back to its default, so you were running on the wrong model with nothing saying so -- exactly the gap #92 warned about in its own comment. The parser now knows per agent which shape it is reading. Grok Build joins as a full third agent. It sits close to claude: --session-id, --resume and the same six values behind --permission-mode (measured from `grok --help` 1.0.13). What differs: there is no -n, and the equivalent of --append-system-prompt is called --rules. Its transcript is looked up by session id rather than by path, because grok URL-encodes the working directory and falls back to a slug plus an undocumented hash above 255 bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190.
Three things that turned out to share one code path.
Pinning a version already worked, but nothing showed it. The model field is free text and
claude --modeltakes a full model name; the suggestion list only offered aliases.claudecannot enumerate its models (nomodelssubcommand, no catalogue on disk), so the names come frommodels.jsonin the config folder — seeded once, never touched by the code afterwards, re-read on every fill so an edit counts during a running session, and what you type yourself is appended after a successful start. A list in the source is what #92 removed on purpose.agy modelswas parsed wrong. It prints two tab-separated columns now, and the whole line went to--model. Agy accepts an unknown model silently and falls back to its default, so this failed invisibly.model_from_linenow knows the shape per agent.Grok Build is a third agent.
--session-id,--resumeand the same six--permission-modevalues as claude (measured on grok 1.0.13); no-n, and--rulesinstead of--append-system-prompt. Its transcript is found by session id, because grok URL-encodes the working directory and falls back to a slug plus an undocumented hash above 255 bytes.Verified
#[ignore]integration tests run against the realagyandgrokbinaries and come back clean.<option>lines mirror the existing agy ones andnode --checkis green.