The tab-group number counts the tabs in one folder, not all of them - #197
Open
astetic-dev wants to merge 1 commit into
Open
The tab-group number counts the tabs in one folder, not all of them#197astetic-dev wants to merge 1 commit into
astetic-dev wants to merge 1 commit into
Conversation
Setting it to 4 bundled a folder that held two tabs, because the number gated whether grouping happened at all while the group size itself was hard-coded at two. The label promises the folder, so that is what the number now means: a folder collapses into one tab as soon as it holds that many sessions, and folders below it keep their own tabs, each in its own place in the bar. The total-tab gate goes with it. It bought little -- grouping only ever merges sessions that share a folder, so the crowding of ten agents in ten folders was never helped by it. tabGroupAt becomes tabGroupSize (default 3). A stored number other than the old default moves over unchanged: whoever typed one meant the folder. Fixes #196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196.
Set to 4, the number bundled a folder that held two tabs: it gated whether grouping happened (over all tabs together) while the group size itself was hard-coded at two. The label promises the folder, so that is what the number now means.
tabGroupAt->tabGroupSize, default 3. A stored number other than the old default 10 carries over unchanged; 10 (the old default) becomes the new default instead of a silently dead setting.Checked by running the real
tabRows()source against the reporter's own session list (nine sessions, two sharing a folder, setting 4): nine ordinary tabs, no session dropped from the bar. Same for size 4 with a four-session folder, size 2, size 1, and grouping off.