Skip to content

[ty] Enable narrowing for unions of TypedDict #25188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charliermarsh wants to merge 9 commits into
base: main
Choose a base branch
from
+185 −40

Use a separate protocol

9a9d64b
Select commit
Loading
Failed to load commit list.
Open

[ty] Enable narrowing for unions of TypedDict #25188

Use a separate protocol
9a9d64b
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed May 16, 2026 in 0s

Performance Regression: -7.41%

❌ 1 regressed benchmark
✅ 56 untouched benchmarks
⏩ 60 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime pydantic 7.8 s 8.4 s -7.41%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing charlie/td-required-keys (9a9d64b) with main (a7ab646)

Open in CodSpeed

Footnotes

  1. 60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

View more details on CodSpeed HQ