[flake8-type-checking] Add unquoted-type-checking-only-import (TC200)#25203
Open
anishgirianish wants to merge 1 commit into
Open
[flake8-type-checking] Add unquoted-type-checking-only-import (TC200)#25203anishgirianish wants to merge 1 commit into
anishgirianish wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
TC200(unquoted-type-checking-only-import), which flags annotation references to imports defined only insideif TYPE_CHECKING:blocks. The fix wraps the annotation in quotes via the existingquote_annotationhelper.Naturally silent on:
from __future__ import annotationsfilesDefers to
TC004when both rules are enabled to avoid fix circulation, same pattern asTC007 ↔ TC004.Closes #5753.
Test plan
AnnAssign, class body, subscripts, unions, attribute access, parenthesized and multi-line annotations, already-quoted (triple-quoted included).TC004coordination verified via a dedicated test.