[ty] add a lint rule to detect redundant assert statements#25204
Open
InvalidPathException wants to merge 2 commits into
Open
[ty] add a lint rule to detect redundant assert statements#25204InvalidPathException wants to merge 2 commits into
InvalidPathException wants to merge 2 commits into
Conversation
InvalidPathException
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Memory usage reportMemory usage unchanged ✅ |
|
InvalidPathException
force-pushed
the
main
branch
from
eb60b42 to
494903c
Compare
InvalidPathException
force-pushed
the
main
branch
from
7b1deca to
e8befcc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#3401
There are some assertions that are clearly always
True/Falseand ty already has this information to support reasonably good detection.This PR adds this (off by default) feature.
Test Plan
Added a test for type-based redundant assertion, and redundant assertions after augmented assignment like
x-=1.