Fix PLR1733 and PLR1736 loop false positives#25206
Open
ya-nsh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
for/elseblocks, matching the existing PLR1733 behaviorfortargets that rebind the index or value variable as modifications, avoiding unsafe PLR1733/PLR1736 replacements after shadowingCloses #25182.
Test Plan
CARGO_PROFILE_DEV_OPT_LEVEL=1 CARGO_PROFILE_DEV_DEBUG=line-tables-only INSTA_UPDATE=always INSTA_FORCE_PASS=1 cargo test -p ruff_linter rules::pylint::tests::rules -- PLR1733_unnecessary_dict_index_lookup.py PLR1736_unnecessary_list_index_lookup.pycargo fmt --checkuvx prek run --files crates/ruff_linter/src/rules/pylint/helpers.rs crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_index_lookup.rs crates/ruff_linter/resources/test/fixtures/pylint/unnecessary_dict_index_lookup.py crates/ruff_linter/resources/test/fixtures/pylint/unnecessary_list_index_lookup.py crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR1736_unnecessary_list_index_lookup.py.snap