pyupgrade/UP031: fix diagnostic range for non-convertible printf-style format strings#25209
Open
Dev-X25874 wants to merge 1 commit into
Open
pyupgrade/UP031: fix diagnostic range for non-convertible printf-style format strings#25209Dev-X25874 wants to merge 1 commit into
Dev-X25874 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
UP031(printf-string-formatting), two early-return paths that reporta
PrintfStringFormattingdiagnostic were usingstring_expr.range()(theformat string literal only) instead of
bin_op.range()(the full"..." % (...)expression).This meant the squiggly underline in editors pointed at just the string
literal, not the complete binary expression — inconsistent with the
successful-conversion path on line 510, which correctly uses
bin_op.range().Fix: replace
string_expr.range()withbin_op.range()on both early-returndiagnostic calls (lines 394 and 455).
Test Plan
Manually verified by tracing both early-return paths in
printf_string_formatting.rsand confirming the range argument now matchesthe successful-conversion path. Existing snapshot tests continue to pass
unchanged.