[ty] Ignore _generate_next_value_ with custom construction hooks#25210
Merged
Conversation
charliermarsh
changed the title
_generate_next_value_ with custom construction hooks
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Memory usage reportMemory usage unchanged ✅ |
|
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…stral-sh#25210) ## Summary One oversight in my changes to astral-sh#25196: if a custom `__new__` is defined, we should treat the alias value as `Any`, rather than relying on `_generate_next_value_`. This matches Pyright, for example. E.g., given: ```python class E(Enum): @staticmethod def _generate_next_value_(...) -> Literal["x"]: return "x" def __new__(cls, value: str): obj = object.__new__(cls) obj._value_ = object() return obj A = auto() B = auto() ``` Prior to this change, we treated `B` as an alias of `A`; but if `__new__` is defined, we don't attempt to detect the alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One oversight in my changes to #25196: if a custom
__new__is defined, we should treat the alias value asAny, rather than relying on_generate_next_value_. This matches Pyright, for example.E.g., given:
Prior to this change, we treated
Bas an alias ofA; but if__new__is defined, we don't attempt to detect the alias.