Skip to content

Ban graalpy and pypy as script/gui entry point names#19536

Merged
konstin merged 2 commits into
mainfrom
zsol/ban-uv-venv-launcher-collisions
May 26, 2026
Merged

Ban graalpy and pypy as script/gui entry point names#19536
konstin merged 2 commits into
mainfrom
zsol/ban-uv-venv-launcher-collisions

Conversation

@zsol
Copy link
Copy Markdown
Member

@zsol zsol commented May 22, 2026

This is a followup to #19535, and it extends the reserved script names to include graalpy and the forms of pypy that uv venv supports.

@zsol zsol force-pushed the zsol/ban-uv-venv-launcher-collisions branch from 417a003 to 97fc88b Compare May 22, 2026 16:04
@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot Bot commented May 22, 2026

uv test inventory changes

This PR changes the tests when compared with the latest main baseline.

  • Added tests: 4
  • Removed tests: 0
  • Changed suites: 1
uv::it: +4 / -0

Added:

  • uv::it::pip_install::reject_graalpy_wheel_entrypoint_name
  • uv::it::pip_install::reject_pypy_major_wheel_entrypoint_name
  • uv::it::pip_install::reject_pypy_wheel_entrypoint_name
  • uv::it::pip_install::reject_windows_rewritten_pypy_wheel_entrypoint_name

Removed: none

@zsol zsol marked this pull request as ready for review May 22, 2026 17:52
Copy link
Copy Markdown
Member

@EliteTK EliteTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure we need this many integration tests for this.

Maybe a unit test that calls whatever function and then an integration test for the error message?

But that doesn't need to be done here.

@zsol zsol enabled auto-merge (squash) May 26, 2026 09:54
@konstin konstin disabled auto-merge May 26, 2026 13:43
@konstin konstin enabled auto-merge (squash) May 26, 2026 13:44
@konstin konstin closed this May 26, 2026
auto-merge was automatically disabled May 26, 2026 13:44

Pull request was closed

@konstin konstin reopened this May 26, 2026
@konstin konstin enabled auto-merge (squash) May 26, 2026 13:44
@konstin konstin merged commit 57341ee into main May 26, 2026
165 of 168 checks passed
@konstin konstin deleted the zsol/ban-uv-venv-launcher-collisions branch May 26, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants