Avoid modifying process with --env-file in uv run#19567
Merged
Conversation
woodruffw
reviewed
May 26, 2026
|
|
||
| // Read from the `.env` file, if necessary. | ||
| for env_file_path in env_file.iter().rev().map(PathBuf::as_path) { | ||
| match dotenvy::from_path(env_file_path) { |
Member
There was a problem hiding this comment.
Maybe we could also ban this API via clippy.toml? Along with the other in-place env mutation APIs 🙂
woodruffw
approved these changes
May 26, 2026
Member
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
LGTM, one suggestion for banning these APIs permanently.
zanieb
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We changed this for
uv tool runin #19343, but missed this other site.