DEP: add missing lower bounds to direct dependencies - #100
Conversation
d95d4bd to
3b96c73
Compare
| @@ -1,5 +1,11 @@ | |||
| # Changelog | |||
|
|
|||
| ## Unreleased | |||
There was a problem hiding this comment.
Section format should be
## X.Y (unreleased)There was a problem hiding this comment.
should I use a literal X.Y or am I supposed to guess what the next version number should be ?
| ## Unreleased | ||
|
|
||
| - Python 3.10 or newer is now required [#94] | ||
| - Lower bounds were added to all direct dependencies [#100] |
There was a problem hiding this comment.
I ran uv pip install . --resolution=lowest and iteratively added packages to --only-binary='<pkgs>' until the only thing that didn't install from a wheel was sphinx-astropy itself. Then I bumped 3 direct dependencies some more (each bump is its own commit) to their oldest versions that didn't require setuptools at runtime (because I'm trying to eliminate it from astropy's own runtime tree)
There was a problem hiding this comment.
sphinx-astropy is also used downstream that might need older versions. Might need to ask the astropy-dev list about this PR, just in case.
There was a problem hiding this comment.
if anyone needs older versions why would they need to upgrade sphinx-astropy ?
There was a problem hiding this comment.
I cannot guess people's motivation. All I am saying is that we don't usually bump minversions in auxiliary packages like this one unless we really have to, and we need to think of packages that are not astropy.
There was a problem hiding this comment.
Of course. But it's also impossible to tell what users are currently expecting precisely because there are no lower bounds in the first place. I would expect any breakage caused by such a change to be very unlikely, and if it happened anyway, the likelyhood that we can avoid it by trying to reach out first seems vanishingly small. I honestly don't think it's worth the trouble, when the alternative (revert a bump and re-release) is extremely cheap.
There was a problem hiding this comment.
please dont' mess with these aux packages; we do pin to lower bounds if/when they are needed for a reason. These are available as a collection of other packages, there is absolutely no need for overengineering and adding version limits here.
|
I don't think the resistance met here is justified but I'm also not going to fight over it. |
3 participants
No description provided.