Skip to content

Re-enable sound preview on Linux#54

Open
dafitius wants to merge 1 commit intoatampy25:mainfrom
dafitius:remove-audio-block
Open

Re-enable sound preview on Linux#54
dafitius wants to merge 1 commit intoatampy25:mainfrom
dafitius:remove-audio-block

Conversation

@dafitius
Copy link
Copy Markdown
Contributor

@dafitius dafitius commented Sep 6, 2025

The Webkit bug preventing audio playback on Linux seems to have been fixed with the Tauri v2 upgrade.
This PR enables access to the playback elements again.

Summary by CodeRabbit

  • New Features
    • Audio previews are now available across all platforms.
  • Improvements
    • Multi-audio resources display the resource name above the waveform.
    • Clear “No linked audio” message shown when no audio is available.
    • Per-track download remains available for multi-audio previews.
  • Bug Fixes
    • Ensured audio previews render consistently regardless of platform.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 6, 2025

Walkthrough

Removes platform-specific gating and unconditionally renders audio previews. For single audio, always shows WaveformPlayer when data.data.wav_path exists. For multi-audio, always shows name, renders MultiWaveformPlayer when wav_paths exist with a download event dispatch; otherwise shows “No linked audio”. Simplifies control flow by removing platform() awaits.

Changes

Cohort / File(s) Summary of Changes
Resource overview editor
src/lib/editors/resourceoverview/ResourceOverviewEditor.svelte
Removed Linux-only gating and platform() awaits; always render WaveformPlayer for data.data.wav_path; for multi-audio, always show data.data.name, render MultiWaveformPlayer when wav_paths present and dispatch on:download with id/index; show “No linked audio” when empty; simplified control flow.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e772ba1 and a630ddc.

📒 Files selected for processing (1)
  • src/lib/editors/resourceoverview/ResourceOverviewEditor.svelte (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build (ubuntu-24.04)
  • GitHub Check: build (windows-latest)

Comment thread src/lib/editors/resourceoverview/ResourceOverviewEditor.svelte
Comment thread src/lib/editors/resourceoverview/ResourceOverviewEditor.svelte
Comment thread src/lib/editors/resourceoverview/ResourceOverviewEditor.svelte
Comment thread src/lib/editors/resourceoverview/ResourceOverviewEditor.svelte
@dafitius dafitius changed the title Remove block sound preview on Linux Re-enable sound preview on Linux Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant