Skip to content

Add ReadKey trait and pass it along to all printers#85

Merged
atanunq merged 11 commits into
atanunq:masterfrom
hasezoey:moreTestOptions
Nov 22, 2025
Merged

Add ReadKey trait and pass it along to all printers#85
atanunq merged 11 commits into
atanunq:masterfrom
hasezoey:moreTestOptions

Conversation

@hasezoey
Copy link
Copy Markdown
Contributor

@hasezoey hasezoey commented Nov 8, 2025

This is so that we can test each function for what it outputs to STDOUT and can input whatever a terminal might respond with.
Currently only kitty's has_local_support function & sixel's check_device_attrs have tests. Other printers and conditions may follow.

Originally part of #79, but moved here for easier review & earlier inclusion.

Comment thread src/printer/read_key.rs
Comment thread src/printer/read_key.rs
@atanunq
Copy link
Copy Markdown
Owner

atanunq commented Nov 22, 2025

Made a small commit to change stdin and stdout order, I hope you don't mind. As always, thank you, I appreciate your work and insight!

@atanunq atanunq merged commit c2411a6 into atanunq:master Nov 22, 2025
3 checks passed
@hasezoey hasezoey deleted the moreTestOptions branch November 22, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants