fix(middleware): map non-disconnect OperationCanceled to 504 - #24
Merged
Merged
Conversation
- Gate the silent OperationCanceledException arm on
HttpContext.RequestAborted.IsCancellationRequested so that only true
upstream-client disconnects are swallowed
- Add OperationCanceledException -> HttpStatusCode.GatewayTimeout to
ExceptionMappingResolver default mappings; covers TaskCanceledException
via the existing inheritance walk
- Restore correct error response when a downstream HttpClient.Timeout (or
other handler-side cancellation) fires while the upstream client is
still connected, instead of silently returning 200 OK with empty body
- Add tests for downstream-timeout 504, base OperationCanceled 504,
upstream-disconnect silent path, custom-mapping override (408), and a
TimeoutException 504 regression
- Update ATC coding rules to v1.0.1 across root/src/test editorconfigs
and add v1.1.0 editorconfig for the new sample/Demo.AppHost project
- Drop Asyncify and SecurityCodeScan.VS2019 analyzers; bump Atc.Analyzer
0.1.17 -> 0.1.23, Meziantou.Analyzer 2.0.267 -> 3.0.58, SonarAnalyzer
10.17 -> 10.25
- Bump runtime packages across sample apps (Atc 3.0.16 -> 3.0.67,
Asp.Versioning.* 8.1 -> 10.0, Mapster 7.4 -> 10.0, EF Core InMemory
10.0.1 -> 10.0.7, OpenTelemetry.* 1.14 -> 1.15, MudBlazor 8.15 -> 9.4,
Aspire.AppHost.Sdk 13.1.0 -> 13.2.4)
- Bump test infrastructure (Mvc.Testing 10.0.1 -> 10.0.7,
Microsoft.NET.Test.Sdk 18.0.1 -> 18.5.1, xunit.v3.mtp-v2 3.2.1 ->
3.2.2, Atc.Rest.FluentAssertions / Atc.Test bumps)
- Reformat sample sources to match the new analyzer rules (parameter
line splits, GlobalUsings reorganization)
perkops
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
🐛 Fixes
✨ Features
📦 Dependencies
🔧 Configuration
🎨 Styling
📝 Documentation
Notes
as a minor bump in release notes
silently with no body written
to a follow-up PR