Introduce Direction enum for OrderField + Introduce Conjunction enum for WhereGroup#23
Closed
Introduce Direction enum for OrderField + Introduce Conjunction enum for WhereGroup#23
Conversation
JulianVennen
requested changes
Aug 7, 2025
| const ASCENDING = 0; | ||
| const DESCENDING = 1; | ||
| const int ASCENDING = 0; | ||
| const int DESCENDING = 1; |
Member
There was a problem hiding this comment.
I think this would be better as an enum. The value doesn't actually mean anything useful.
| const AND = 0; | ||
| const OR = 1; | ||
| const int AND = 0; | ||
| const int OR = 1; |
Member
There was a problem hiding this comment.
I think this would be better as an enum. The value doesn't actually mean anything useful.
pavog
changed the title
JulianVennen
requested changes
Aug 7, 2025
JulianVennen
approved these changes
Aug 8, 2025
matthi4s
requested changes
Feb 3, 2026
| * Direction constants | ||
| */ | ||
| const ASCENDING = 0; | ||
| const DESCENDING = 1; |
Member
There was a problem hiding this comment.
Keeping them and setting them to the enum value is probably better for at least some backwards compatibility. You can also mark them as deprecated via phpdoc.
| * Conjunction values | ||
| */ | ||
| const AND = 0; | ||
| const OR = 1; |
Member
There was a problem hiding this comment.
Keeping them and setting them to the enum value is probably better for at least some backwards compatibility. You can also mark them as deprecated via phpdoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.