Skip to content

Fix Dryer capabilities #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Allram wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Dryer capabilities #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f33365
Fix Dryer capabilities
Allram Sep 14, 2023
ad7200e
More job statuses
Allram Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 64 additions & 10 deletions .homeycompose/capabilities/samsung_dryer_current_job_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,40 +8,94 @@
"uiComponent": "sensor",
"icon": "/assets/capabilities/samsung_dryer_current_job_state.svg",
"values": [
{
"id": "cooling",
"title": {
"en": "Cooling"
}
},
{
"id": "delayWash",
"title": {
"en": "Delayed start"
}
},
{
"id": "drying",
"title": {
"en": "Drying"
}
},
{
"id": "finished",
"title": {
"en": "Finished"
}
},
{
"id": "none",
"title": {
"en": "None"
}
},
{
"id": "idle",
"id": "refreshing",
"title": {
"en": "Idle"
"en": "Refreshing"
}
},
{
"id": "dry",
"id": "weightSensing",
"title": {
"en": "Drying"
"en": "Weight sensing"
}
},
{
"id": "rinse",
"id": "wrinklePrevent",
"title": {
"en": "Rinsing"
"en": "Wrinkle prevention"
}
},
{
"id": "spin",
"id": "dehumidifying",
"title": {
"en": "Spinning"
"en": "Dehumidifying"
}
},
{
"id": "finished",
"id": "aiDrying",
"title": {
"en": "Finished"
"en": "AI drying"
}
},
{
"id": "sanitizing",
"title": {
"en": "Sanitizing"
}
},
{
"id": "internalCare",
"title": {
"en": "Cleaning"
}
},
{
"id": "freezeProtection",
"title": {
"en": "Freeze protection"
}
},
{
"id": "continousDehumidifying",
"title": {
"en": "Continous Dehumidifying"
}
},
{
"id": "thawingFrozenInside",
"title": {
"en": "Thawing frozen inside"
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions drivers/dryer/device.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module.exports = class SmartThingsDeviceDryer extends SmartThingsDevice {
{
homeyCapabilityId: 'samsung_dryer_progress_remaining_time',
smartThingsComponentId: 'main',
smartThingsCapabilityId: 'samsungce.washerOperatingState',
smartThingsCapabilityId: 'samsungce.dryerOperatingState',
Copy link
Copy Markdown
Contributor

@ttherbrink ttherbrink Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not recieved any reports that these capabilities are broken. Could you elaborate on what is broken and how this solution fixes it?

Copy link
Copy Markdown
Contributor Author

@Allram Allram Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes so that it's the dryer operation and not washer operation.
I did not get any updates on my dryer when this was set to washer, and when I went through Samsungs api the correct setting to get updates is 'dryerOperatingState' for dryer and not 'washerOperatingState' as that is for washing machines.

smartThingsAttributeId: 'remainingTimeStr',
async onReport({ value }) {
return value;
Expand All @@ -27,7 +27,7 @@ module.exports = class SmartThingsDeviceDryer extends SmartThingsDevice {
homeyCapabilityId: 'samsung_dryer_current_job_state',
smartThingsComponentId: 'main',
smartThingsCapabilityId: 'samsungce.dryerOperatingState',
smartThingsAttributeId: 'washerJobState',
smartThingsAttributeId: 'dryerJobState',
async onReport({ value }) {
if (value === 'finished') {
this.homey.flow
Expand Down