[mvorisek]

extracted from #2317

[DarkSide666]

Isn't this good to merge too?

[mvorisek]

The "dynamic required" must be based on getFormDisplayRules() rules to be elegant and what atk4 is all about. No need to reinvent wheel, just parse the Fomantic-UI rules, code the checks 1:1 and evaluate them in PHP.

[DarkSide666]

You say no need to reinvent the wheel, but coding all Fomantic-UI rules into Atk php side will be duplication of code too.

Basically what has to be there is - if field is visible in form, then it should be filed. That's all. But sadly only client side (browser) knows field visibility as it's dynamic. So I can't validate that on backend php based on that.
Or am I missing something?

[mvorisek]

You say no need to reinvent the wheel, but coding all Fomantic-UI rules into Atk php side will be duplication of code too.

That is hovewer the easiest part and maybe not even rules are needed to be supported. We can throw instead :)

Basically what has to be there is - if field is visible in form, then it should be filed. That's all. But sadly only client side (browser) knows field visibility as it's dynamic. So I can't validate that on backend php based on that. Or am I missing something?

Why? The rules are based on other fields and we have them posted back to the server.

See the coverage (-0.11 %), the current PR code is simply not good to be integrated.