Repository navigation
Fix table totals when column has a decorator - #2323
Open
officialasishkumar wants to merge 1 commit into
Open
officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Table::addDecorator() turns the Table::$columns entry into a list of column instances, but Table::getTotalsRowHtml() expected a single column. Any table combining a decorated column with addTotals() failed to render with "Call to a member function getTag() on array", or getTotalsCellHtml() when the totals plan aggregated the decorated column. Use the first formatter for the totals cell, the same way as Table::getHeaderRowHtml() does for the header cell.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1799
Table::addDecorator()turns theTable::$columnsentry into a list of column instances, butTable::getTotalsRowHtml()expected a single column. Any table combining a decorated column withaddTotals()failed to render withCall to a member function getTag() on array, or withgetTotalsCellHtml()when the totals plan aggregates that column.The totals cell now uses the first formatter, the same way
Table::getHeaderRowHtml()does for the header cell.The new test decorates a column for each kind of totals cell (text, aggregate and no plan). It fails with the error above without the fix.