Repository navigation
Focus search input when search button is clicked with empty input - #2324
Open
officialasishkumar wants to merge 1 commit into
Open
officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Clicking the magnifying glass of JsSearch did nothing when no text was entered, so users had to click a 2nd time into the input to start typing. Move focus to the input in that case. Clicking the button with a text entered still submits the search and clicking it with an active search still clears the search. Add a generic "Element ... should be focused" Behat step to test this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2166
Clicking the magnifying glass in
JsSearchdid nothing when no text was entered, so users had to click a 2nd time into the input to start typing. The input is now focused in that case.As requested in #2166 (comment), the other behaviour is kept: with text entered the button still submits the search, and with an active search it still clears it. This applies with
autoQueryboth enabled and disabled, because only the empty input case changed.Added a generic
Element ... should be focusedBehat step and agrid.featurescenario, which fails without the JS change.public/jswas rebuilt usingnpm run build. The baseline build was byte-identical to the committed files, so the bundle diff contains only this change.