This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Replace the body of ::toDelta method with @getExent().#113
Open
kseo wants to merge 1 commit intoatom:masterfrom
kseo:toDelta
Open
Replace the body of ::toDelta method with @getExent().#113kseo wants to merge 1 commit intoatom:masterfrom kseo:toDelta
kseo wants to merge 1 commit intoatom:masterfrom
kseo:toDelta
Conversation
::getExtent and ::toDelta do the exactly same thing.
Contributor
|
Thanks for noticing this. I believe we can just 🔥 |
Author
|
Sure. If it is not used, we don't need to duplicate the method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
::getExtent and ::toDelta do the exactly same thing.