This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
79e6eec to
a34cb8d
Compare
94e4826 to
1fffd5c
Compare
da110dd to
816bc75
Compare
Contributor
|
Is this PR still relevant? I know you are not involved with Atom anymore much, but I want to know if I should spend time on reviving this pull request. Linter uses markers and decorators heavily, and any performance improvement can improve the overall experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscribing and emitting events for every single marker is an expensive operation for a number of reasons, and its cost increases as the number of markers goes up: for instance, just emitting the event with no information becomes onerous when there are lots of markers and/or subscribers.
With this pull-request we want to make subscribing to individual marker event an anti-pattern and thus deprecate it. We have planned to do so by changing
MarkerLayer.prototype.onDidUpdatein two ways:created,updated,touchedanddestroyedsets in the event object, which respectively indicate the ids for markers that were created, manually updated, updated because of a textual change, and destroyed./cc: @nathansobo