This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
Contributor
Author
|
The failing test doesn't appear to be related to this change at all, since the code would either die before even starting, or work the exact same as before from this. |
The `cpy-cli` dependency is only used in the `compile` script (which is called by `prepublish`), as such it should have been a `devDependency` from the start but was mistakenly added as a regular `dependency` in GH280. This moves it to where it should have been.
Arcanemagus
force-pushed
the
la-cpy-cli-devDependency
branch
from
5e79cfa to
35d8663
Compare
Contributor
Author
|
Looks like this build is showing a flaky test, rebased on |
1 task
Contributor
Author
|
Can confirm that this fixes atom/atom#17125 🎉. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cpy-clidependency is only used in thecompilescript (which is called byprepublish), as such it should have been adevDependencyfrom the start but was mistakenly added as a regulardependencyin #280. This moves it to where it should have been.Fixes atom/atom#17125.