This repository was archived by the owner on Dec 15, 2022. It is now read-only.
[FEATURE/FIX] Ensuring NodeJS 12 Compatibility#315
Open
sidneys wants to merge 4 commits intoatom:masterfrom
Open
[FEATURE/FIX] Ensuring NodeJS 12 Compatibility#315sidneys wants to merge 4 commits intoatom:masterfrom
sidneys wants to merge 4 commits intoatom:masterfrom
Conversation
…rom GitHub to incorporate the fixes required for Nodejs 12 compatibility. upgrades other dependencies to modern standards.
…endenciy modules (via npx) instead of referencing global namespace apps. also replaces the deprecated "prepublish" lifecycle phase with the newer "prepare" phase to ensure that the compilation is also done reliably when installing from Git oder locally (see github.com/npm/npm/issues/10074)
…nimum version of the substring package required to fully support Nodejs 12 environments
|
Thanks @sidneys! And thanks for the detailed pull request description, it's always helpful - however, I'm not sure if there was an issue with GitHub displaying our templates when you created the PR but can you use our existing PR template? Also, I see there are CI failures - do you think they're unrelated to your changes? If so, can you leave a comment explaining why the failures are unrelated as mentioned in our CONTRIBUTING guide? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👟 Description & Background
As this Pull Request is not addressing a specific functional issue in code, but rather constitutes a list of fixes to enable the use of this module with a NodeJS 12 context. Currently, referencing
text-bufferin NodeJS 12 projects leads to cascading (and hard-to-decipher) build errors in downstream text editing apps like slap. Underlying reasons are build configuration issues, an incompatible upstream dependency and code style issues, and are all being adressed by the PR.👟 Steps to Reproduce (S2R)
npm -g install 'https://github.com/cancerberoSgx/slap'🤷🏽♂️ Main Issues
atom/substringcauses problems in a nodejs 12 environment🎯 Conducted Changes
node_modulesbinaries ofcoffeescript,rimraforcpyprepublishphase because it does not get called when installing modules from Git (and due to deprecation). Thepreparephase now used initiates the compilation process during installations regardless of context.🏡 Context
Version Tested
v13.17.0
Installation Approach
nvm, npm
Operating System
Apple macOS Mojave 10.14.6