Bugfix/invalid structures - #11
Merged
Merged
Conversation
Contributor
|
Thanks @crhysc . Did you check if the pytests/examples on the README.md file pass with the new PR? |
Collaborator
Author
|
I patched inverse_models.py and inverse_predict.py, and the REAMDME tests pass. Should be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered issues where an invalid lattice prediction will crash the evaluate() loop and crash the train/test script. Here is a sample error that I got on test structure #44:
genmat None
Traceback (most recent call last):
File "/users/crc00042/repositories/atomgpt/atomgpt/inverse_models/inverse_models.py", line 654, in
main(config_file=args.config_name)
File "/users/crc00042/repositories/atomgpt/atomgpt/inverse_models/inverse_models.py", line 639, in main
evaluate(
File "/users/crc00042/repositories/atomgpt/atomgpt/inverse_models/inverse_models.py", line 241, in evaluate
+ Poscar(gen_mat).to_string().replace("\n", "\n")
File "/users/crc00042/miniforge3/envs/ramangpt/lib/python3.10/site-packages/jarvis/io/vasp/inputs.py", line 56, in to_string
+ str(self.atoms.lattice_mat[0][0])
AttributeError: 'NoneType' object has no attribute 'lattice_mat'
These code changes will prevent evaluate() crashes and make two benchmark CSVs. One will contain structures that have valid reconstructions, and the other will contain structures whose reconstructions are invalid. Let me know what you think