Draft
Conversation
Add Indochina Time (ICT, UTC+7) and Philippine Time (PHT, UTC+8) to Time::Zone, enabling parsing of date strings with these common Southeast Asian timezone abbreviations. Closes atoomic#20
|
How about NST, UTC-3.5 and NDT, UTC-2.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Indochina Time (ICT, UTC+7) and Philippine Time (PHT, UTC+8) to Time::Zone.
Why
These are common timezones used across Southeast Asia (~750M people). Date strings containing "ICT" or "PHT" currently fail to parse. Requested in issue #20 since 2017.
How
Two entries added to the
@Zonearray inTime::Zone. Tests added tot/zone.t.Testing
prove -l t/zone.t— 30/30 pass (29 new + 1 pre-existing DST-dependent failure from test failure after daylight savings time started #58)Closes #20
🤖 Generated with Claude Code