fix: use standard 2-letter German weekday abbreviations#63
Draft
Koan-Bot wants to merge 1 commit intoatoomic:mainfrom
Draft
fix: use standard 2-letter German weekday abbreviations#63Koan-Bot wants to merge 1 commit intoatoomic:mainfrom
Koan-Bot wants to merge 1 commit intoatoomic:mainfrom
Conversation
Change @dows from 3-letter (Son, Mon, Die, Mit, Don, Fre, Sam) to the standard 2-letter forms (So, Mo, Di, Mi, Do, Fr, Sa) in both German and Austrian language modules. The 2-letter abbreviations match POSIX locale output (LC_ALL=de_DE.UTF-8) on Linux and FreeBSD, and are the universally recognized standard in German-speaking countries. Closes atoomic#34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change German and Austrian weekday abbreviations from non-standard 3-letter forms to the standard 2-letter forms used by POSIX locales.
Why
The current abbreviations (Son, Mon, Die, Mit, Don, Fre, Sam) are non-standard truncations. German-speaking countries universally use 2-letter forms (So, Mo, Di, Mi, Do, Fr, Sa), which is confirmed by
LC_ALL=de_DE.UTF-8 strftime "%a"on Linux and FreeBSD. Issue reported by two CPAN authors (MBETHKE, SREZIC) in 2016.How
Updated
@DoWsin bothGerman.pmandAustrian.pm. The parser (_build_lookups()) automatically rebuilds reverse-lookup hashes, so parsing the new abbreviations works out of the box.Testing
t/format.t,t/lang-data.t,t/lang.t— all 534 tests passCloses #34
🤖 Generated with Claude Code
Quality Report
Changes: 4 files changed, 6 insertions(+), 6 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline