JUMPIF and JUMPIFNOT can make "Condition" be null, causing Unluau to completely error out#33
Open
karl-police wants to merge 1 commit into
Open
JUMPIF and JUMPIFNOT can make "Condition" be null, causing Unluau to completely error out#33karl-police wants to merge 1 commit into
karl-police wants to merge 1 commit into
Conversation
karl-police
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No clue if my changes are correct or not, even if they do work.
Input Example:
https://github.com/MaximumADHD/Roblox-Client-Tracker/blob/79d958e1c5e9acff1f1a053873852d7c3a682b16/BuiltInPlugins/AnimationClipEditor/Bin/main.luac
Currently, this Unluau is unable to generate Pseudocode from this input, because it errors out, however this pull request addresses this issue is some... strange way...
I have no clue if that what I did is correct.
So here are the differences:
https://www.diffchecker.com/JJD5VjjH/
This is how the differences look like with both of my "patches" applied.
https://www.diffchecker.com/oEnOdmc1/