fix: cap session tab title length - #68
Merged
Merged
Conversation
Contributor
Author
Independent Agent review: approvedReview round 1/2 for Session editor-tab labels now flow through a single capped builder (28 code points plus ellipsis, whitespace collapsed) used identically for streaming and idle states, so a long conversation can no longer push sibling tabs out of view and activation does not change label length. Unit tests cover truncation, surrogate safety, whitespace collapse, and the shared-builder wiring. Findings
Reviewer checks
Generated by the independent sandboxed Reviewer Agent. The PR still requires human review and merge. |
auchan
force-pushed
the
fix/issue-63-cap-session-tab-titles
branch
from
September 5, 2026 16:00
6ab564f to
4dd56a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session editor-tab titles now pass through a deterministic code-point-based length cap (28 chars plus ellipsis, whitespace collapsed) applied in the shared tab-title builder, so streaming and idle states always produce the same label length and one long conversation can no longer crowd sibling tabs out of view. Added focused unit tests for truncation, surrogate safety, and the shared builder, plus source assertions locking equal-length caps for both tab states.
Validation
Closes #63