Skip to content

fix: halve thinking block height - #74

Merged
auchan merged 2 commits into
mainfrom
fix/issue-73-halve-thinking-block-height
Sep 6, 2026
Merged

auchan merged 2 commits into
mainfrom
fix/issue-73-halve-thinking-block-height

Conversation

@pi-claw-agent

@pi-claw-agent pi-claw-agent Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Halved the Thinking block content heights: the finished scrollable reader caps at min(60vh, 260px) instead of min(60vh, 520px), and the live streaming tail caps at 160px instead of 320px. Scroll behavior is unchanged. Added focused style regression tests.

Validation

  • bun install --frozen-lockfile
  • bun run check-types
  • bun run lint
  • bun run compile-tests
  • bun esbuild.js
  • bun esbuild.webview.js
  • xvfb-run -a bun x vscode-test (201 passing)
  • git diff --check

Closes #73

@pi-claw-agent pi-claw-agent Bot added the agent:reviewing Independent Agent review is in progress label Sep 6, 2026
@pi-claw-agent

pi-claw-agent Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Independent Agent review: approved

Review round 1/2 for 766b36b099cc.

The patch halves exactly the two active Thinking-block height caps requested by the issue: the finished scrollable reader max-height changes from min(60vh, 520px) to min(60vh, 260px) and the live streaming tail from 320px to 160px, in the unlayered rules that win the cascade. Overflow behavior and rule layering are untouched, and the added regression tests pin the new values and preserved scroll semantics.

Reviewer checks

  • Inspected git diff main...766b36b and confirmed the changed rules are the effective unlayered caps in media/style.css (no competing later rules; the earlier @layer copies lose the cascade).
  • bun run compile-tests
  • ./node_modules/.bin/mocha --ui tdd out/test/thinking-height.test.js (3 passing)
  • ./node_modules/.bin/eslint src/test/thinking-height.test.ts
  • git diff --check main...766b36b

Generated by the independent sandboxed Reviewer Agent. The PR still requires human review and merge.

@pi-claw-agent pi-claw-agent Bot added agent:pending-approval Independent Agent review passed; awaiting human approval and removed agent:reviewing Independent Agent review is in progress labels Sep 6, 2026
@auchan

auchan commented Sep 6, 2026

Copy link
Copy Markdown
Owner

thinking块max高度在两种模式下改成一样

@auchan auchan added agent:dispatch Request Agent processing and removed agent:pending-approval Independent Agent review passed; awaiting human approval labels Sep 6, 2026
@pi-claw-agent pi-claw-agent Bot added agent:queued Accepted and waiting for Agent capacity and removed agent:dispatch Request Agent processing agent:queued Accepted and waiting for Agent capacity labels Sep 6, 2026
@pi-claw-agent

pi-claw-agent Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Agent iteration 1

Addressed PR #74 feedback: the live streaming Thinking tail now uses the same max height as the finished reader (min(60vh, 260px)) instead of its previous 160px cap, so both thinking modes share one consistent height limit while keeping their per-mode overflow behaviour (auto vs hidden).

Independent Agent review will run on the updated commit. The PR still requires human review and merge.

@pi-claw-agent pi-claw-agent Bot added the agent:reviewing Independent Agent review is in progress label Sep 6, 2026
@pi-claw-agent

pi-claw-agent Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Independent Agent review: approved

Review round 1/2 for 6fe975c32383.

The revised head halves the finished Thinking reader cap to min(60vh, 260px) and unifies the live streaming tail to the same min(60vh, 260px) limit per review feedback, keeping each mode's overflow semantics (reader auto-scroll, live clipped without a nested scrollbar). This satisfies the issue's space-reduction intent and the follow-up consistency request; the focused style tests assert both modes share the identical max-height value and preserve overflow behavior. Note: the PR description in the job still describes the earlier 160px live cap and is stale relative to this head — evidence only, no code impact.

Reviewer checks

  • Inspected git diff main...6fe975c and the delta from the previously reviewed commit 766b36b, plus rule cascade order for the live and reader selectors.
  • bun run compile-tests
  • ./node_modules/.bin/mocha --ui tdd out/test/thinking-height.test.js (3 passing)
  • ./node_modules/.bin/eslint src/test/thinking-height.test.ts
  • git diff --check main...6fe975c

Generated by the independent sandboxed Reviewer Agent. The PR still requires human review and merge.

@pi-claw-agent pi-claw-agent Bot added agent:pending-approval Independent Agent review passed; awaiting human approval and removed agent:reviewing Independent Agent review is in progress labels Sep 6, 2026
@auchan
auchan force-pushed the fix/issue-73-halve-thinking-block-height branch from 6fe975c to 683316d Compare September 6, 2026 07:30
@auchan
auchan merged commit d5dc8df into main Sep 6, 2026
1 check passed
@auchan
auchan deleted the fix/issue-73-halve-thinking-block-height branch September 6, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:pending-approval Independent Agent review passed; awaiting human approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thinking block 高度调整

1 participant