Skip to content

fix: give session action menu an opaque backdrop - #76

Merged
auchan merged 1 commit into
mainfrom
fix/issue-75-opaque-session-menu
Sep 6, 2026
Merged

auchan merged 1 commit into
mainfrom
fix/issue-75-opaque-session-menu

Conversation

@pi-claw-agent

@pi-claw-agent pi-claw-agent Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Session action menus no longer rely on the (often transparent) sideBarSectionHeader token: the menu now paints an editorWidget/editor-background fallback plus a near-opaque color-mix backdrop over the sidebar background, so long session lists no longer bleed through the open menu while a slight translucency is preserved.

Validation

  • bun install --frozen-lockfile
  • bun run check-types
  • bun run lint
  • bun run compile-tests
  • bun esbuild.js
  • bun esbuild.webview.js
  • xvfb-run -a bun x vscode-test (200 passing)
  • git diff --check

Closes #75

@pi-claw-agent pi-claw-agent Bot added the agent:reviewing Independent Agent review is in progress label Sep 6, 2026
@pi-claw-agent

pi-claw-agent Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Independent Agent review: approved

Review round 1/2 for 91df1b77746f.

The session action menu background no longer depends on the possibly-transparent sideBarSectionHeader token: it paints an opaque editorWidget/pi-bg fallback followed by a near-opaque (94%) color-mix backdrop over the sidebar background, so covered session rows no longer bleed through while a slight translucency is preserved. The change is confined to the .session-menu rule; elevation shadow and border are kept, and focused regression tests pin the new declarations.

Reviewer checks

  • Inspected git diff main...91df1b7, the --pi-panel/--pi-bg token chain, and the menu rule within the sidebar webview styles.
  • bun run compile-tests
  • ./node_modules/.bin/mocha --ui tdd out/test/session-menu-backdrop.test.js (2 passing)
  • ./node_modules/.bin/eslint src/test/session-menu-backdrop.test.ts
  • bun run check-types
  • git diff --check main...91df1b7

Generated by the independent sandboxed Reviewer Agent. The PR still requires human review and merge.

@pi-claw-agent pi-claw-agent Bot added agent:pending-approval Independent Agent review passed; awaiting human approval and removed agent:reviewing Independent Agent review is in progress labels Sep 6, 2026
@auchan
auchan merged commit 170b559 into main Sep 6, 2026
1 check passed
@auchan
auchan deleted the fix/issue-75-opaque-session-menu branch September 6, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:pending-approval Independent Agent review passed; awaiting human approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

会话列表的会话行为菜单(session actions)背景不应该透明

1 participant