fix: remove duplicate panel location setting - #89
Conversation
Independent Agent review: approvedReview round 1/2 for The leftover duplicate pi-on-code.chatPanelLocation setting is fully removed: the manifest now publishes exactly one location property (pi-on-code.newChatPanelLocation, default panel), no source or doc reference to the removed key remains (the only hits are tests asserting its absence), and resume/fork open through the plain show() default (column Two), reproducing the previous default of the deleted key. Code-level and manifest defaults are aligned on panel, and focused tests lock the manifest shape and wiring. Reviewer checks
Generated by the independent sandboxed Reviewer Agent. The PR still requires human review and merge. |
|
改成保留一个选项 .chatPanelLocation,无论是new 还是 resumed 都遵循这个设置,默认是panel |
Agent iteration 1Per PR #89 feedback the location setting is now a single pi-on-code.chatPanelLocation (default panel) that both new chats and resumed/forked chats honor; the duplicate pi-on-code.newChatPanelLocation was removed and all three show() call sites route through chatShowColumn("chatPanelLocation"). Tests assert exactly one location property, the panel default, and the shared routing. Independent Agent review will run on the updated commit. The PR still requires human review and merge. |
Independent Agent review: approvedReview round 1/2 for The redundant second location setting is gone: the manifest publishes exactly one property, pi-on-code.chatPanelLocation (default panel, enum panel/splitPanel), and all three panel-opening paths (brand-new chats in addSession, resume, and fork) now route through chatShowColumn("chatPanelLocation"). No source or manifest reference to the removed newChatPanelLocation key remains outside the test asserting its absence, the code-level DEFAULT_CHAT_PANEL_LOCATION is aligned with the manifest default (panel), and setting/code/test changes are coherent. Note: because resume and fork previously used a splitPanel default, unifying them onto this setting means they now default to opening in the active group; this follows the stated PR feedback and is intentional. Reviewer checks
Generated by the independent sandboxed Reviewer Agent. The PR still requires human review and merge. |
Summary
Removed the redundant pi-on-code.chatPanelLocation setting (the leftover from the earlier branch) from the manifest, and resume/fork now open through the plain historical show() default. pi-on-code.newChatPanelLocation remains the single panel-location setting (default panel, aligned with the code-level default) for brand-new chats. Tests updated to assert only one location property exists and that resume/fork no longer reference the removed key.
Validation
Closes #88