Skip to content

fix: remove duplicate panel location setting - #89

Merged
auchan merged 2 commits into
mainfrom
fix/issue-88-remove-duplicate-panel-location
Sep 14, 2026
Merged

auchan merged 2 commits into
mainfrom
fix/issue-88-remove-duplicate-panel-location

Conversation

@pi-claw-agent

@pi-claw-agent pi-claw-agent Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Removed the redundant pi-on-code.chatPanelLocation setting (the leftover from the earlier branch) from the manifest, and resume/fork now open through the plain historical show() default. pi-on-code.newChatPanelLocation remains the single panel-location setting (default panel, aligned with the code-level default) for brand-new chats. Tests updated to assert only one location property exists and that resume/fork no longer reference the removed key.

Validation

  • bun install --frozen-lockfile
  • bun run check-types
  • bun run lint
  • bun run compile-tests
  • bun esbuild.js
  • bun esbuild.webview.js
  • xvfb-run -a bun x vscode-test (235 passing)
  • git diff --check

Closes #88

@pi-claw-agent pi-claw-agent Bot added the agent:reviewing Independent Agent review is in progress label Sep 9, 2026
@pi-claw-agent

pi-claw-agent Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Independent Agent review: approved

Review round 1/2 for f26c6baa6520.

The leftover duplicate pi-on-code.chatPanelLocation setting is fully removed: the manifest now publishes exactly one location property (pi-on-code.newChatPanelLocation, default panel), no source or doc reference to the removed key remains (the only hits are tests asserting its absence), and resume/fork open through the plain show() default (column Two), reproducing the previous default of the deleted key. Code-level and manifest defaults are aligned on panel, and focused tests lock the manifest shape and wiring.

Reviewer checks

  • Inspected git diff main...f26c6ba and scanned src, package.json, media, scripts, agent-wiki, and docs for leftover chatPanelLocation references and placement-key wiring.
  • bun run compile-tests
  • ./node_modules/.bin/mocha --ui tdd out/test/chat-panel-location.test.js (4 passing)
  • ./node_modules/.bin/eslint src/test/chat-panel-location.test.ts src/chat-panel-location.ts
  • bun run check-types
  • git diff --check main...f26c6ba

Generated by the independent sandboxed Reviewer Agent. The PR still requires human review and merge.

@pi-claw-agent pi-claw-agent Bot added agent:pending-approval Independent Agent review passed; awaiting human approval and removed agent:reviewing Independent Agent review is in progress labels Sep 9, 2026
@auchan

auchan commented Sep 14, 2026

Copy link
Copy Markdown
Owner

改成保留一个选项 .chatPanelLocation,无论是new 还是 resumed 都遵循这个设置,默认是panel

@auchan auchan added agent:dispatch Request Agent processing and removed agent:pending-approval Independent Agent review passed; awaiting human approval labels Sep 14, 2026
@pi-claw-agent pi-claw-agent Bot added agent:queued Accepted and waiting for Agent capacity and removed agent:dispatch Request Agent processing agent:queued Accepted and waiting for Agent capacity labels Sep 14, 2026
@pi-claw-agent

pi-claw-agent Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Agent iteration 1

Per PR #89 feedback the location setting is now a single pi-on-code.chatPanelLocation (default panel) that both new chats and resumed/forked chats honor; the duplicate pi-on-code.newChatPanelLocation was removed and all three show() call sites route through chatShowColumn("chatPanelLocation"). Tests assert exactly one location property, the panel default, and the shared routing.

Independent Agent review will run on the updated commit. The PR still requires human review and merge.

@pi-claw-agent pi-claw-agent Bot added the agent:reviewing Independent Agent review is in progress label Sep 14, 2026
@pi-claw-agent

pi-claw-agent Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Independent Agent review: approved

Review round 1/2 for 0256e738ccc6.

The redundant second location setting is gone: the manifest publishes exactly one property, pi-on-code.chatPanelLocation (default panel, enum panel/splitPanel), and all three panel-opening paths (brand-new chats in addSession, resume, and fork) now route through chatShowColumn("chatPanelLocation"). No source or manifest reference to the removed newChatPanelLocation key remains outside the test asserting its absence, the code-level DEFAULT_CHAT_PANEL_LOCATION is aligned with the manifest default (panel), and setting/code/test changes are coherent. Note: because resume and fork previously used a splitPanel default, unifying them onto this setting means they now default to opening in the active group; this follows the stated PR feedback and is intentional.

Reviewer checks

  • Inspected git diff main...0256e73 and grepped the repository for leftover newChatPanelLocation/chatPanelLocation references and chatShowColumn call sites.
  • bun run compile-tests
  • ./node_modules/.bin/mocha --ui tdd out/test/chat-panel-location.test.js (4 passing)
  • ./node_modules/.bin/eslint src/test/chat-panel-location.test.ts src/chat-panel-location.ts
  • bun run check-types
  • git diff --check main...0256e73

Generated by the independent sandboxed Reviewer Agent. The PR still requires human review and merge.

@pi-claw-agent pi-claw-agent Bot added agent:pending-approval Independent Agent review passed; awaiting human approval and removed agent:reviewing Independent Agent review is in progress labels Sep 14, 2026
@auchan
auchan merged commit 6b2bd78 into main Sep 14, 2026
1 check passed
@auchan
auchan deleted the fix/issue-88-remove-duplicate-panel-location branch September 14, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:pending-approval Independent Agent review passed; awaiting human approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

删除多余的pannel location

1 participant