-
Notifications
You must be signed in to change notification settings - Fork 15
Find a scoped <style> regardless of what precedes it #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NullVoxPopuli
merged 4 commits into
auditboard:main
from
tylerturdenpants:issue-423-dropped-scoped-css-tests
Sep 4, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
acd57f7
Find a scoped <style> regardless of what precedes it
tylerturdenpants 54688f5
Look up the scoped <style> after the count check
tylerturdenpants 8449956
Assert the scoped <style> tests with inline snapshots
tylerturdenpants cee6d1a
Drop the added comments from the Template visitor
tylerturdenpants File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test would be better as an inline snapshot. the individual expects lose context / "the plot", as claude often does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I think all the new tests, actually)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both new tests now assert with snapshots, in 8449956.
The template snapshot carries the whole story on its own -- scoped class postfixed, global block shipped as written, scoped tag removed:
plus the emitted virtual import, same shape as the
lang="scss"tests above.That made the third test ("leaves a preceding global
<style>") a strict subset of this one, so I dropped it rather than keep a near-duplicate. Say the word if you would rather keep it separate.The second-block case stayed a
toThrow, matching babel-plugin.test.ts:99. Babel prefixes the message with the absolute filename, sotoThrowErrorMatchingInlineSnapshotwrites my home directory into the snapshot and only passes on this machine.Both still fail against the pre-fix plugin -- I checked by swapping in the version from main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went back over the whole review. The four comment deletions were one note, not four, and I had only applied it to the tests --
template-plugin.jsstill carried the same kind of prose I had added above the filter and the length check. Both gone in cee6d1a, leaving the one-line comment that was there before this branch. The error message covers what the second one was saying.The diff against
mainfor that file is now just the behaviour change.