This repository was archived by the owner on Jun 24, 2026. It is now read-only.
SOX-78363: fix new line and quote formatting - #18
Closed
sarab-fairnow wants to merge 1 commit into
Closed
sarab-fairnow wants to merge 1 commit into
sarab-fairnow wants to merge 1 commit into
Conversation
| for risk_item in risk_items: | ||
| description = risk_item.get('description', '') | ||
| # Replace all newlines/tabs with a space and clean quotes | ||
| description = re.sub(r'[\r\n\t]+', ' ', description).strip() |
Collaborator
There was a problem hiding this comment.
I'm not sure we should be transforming the data. If this is being exported into CVS/TSV then the tabs/newlines should be escaped as part of the serialization. If the consumer of the CSV/TSV cannot handle properly escaped data - that is something they should fix.
Collaborator
Author
There was a problem hiding this comment.
Ah, good point. Using my DE brain too much. I will reach out to them
sarab-fairnow
marked this pull request as draft
November 7, 2025 15:03
Collaborator
Author
|
Closing as Dayforce will look into fixing the data on their end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.