Change app-id to photo.ansel.ansel #589
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the appstream and desktop file Update the localisation files for the renaming Update whichever other script reference it Signed-off-by: Hubert Figuière <hub@figuiere.net>
|
Jiyone
approved these changes
Dec 12, 2025
Collaborator
|
From what I've read and unless I'm wrong, flatpak doesn't allow capital letters, does they? |
Author
Not sure where you read that, but as a flathub admin / reviewer, I can tell you this is totally false. I did lowercase because:
This can definitely be what you prefer. |
Collaborator
What do you mean ? The capital letter phobia ? We don't have that in Ansel :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the appstream and desktop file
Update the localisation files for the renaming
Update whichever other script reference it
Rationale
app-id are in the form of "reverse domain" + "application name". This application name is Ansel. But the chosen app-id say the application name is "app". For flatpak, and Flathub, "app" isn't acceptable. So it would be rejected in the Flathub app submission.
This PR change the app-id to
photos.ansel.anselall lowercase. This id is case sensitive, so if you preferphotos.ansel.AnselI'd be happy to update this PR to match that.Since there have never been a release of this yet it's a good time to address this, instead of later.