Remove dependence on external tests for fixed-point restart test - #135
Merged
mattfalcone1997 merged 2 commits intoAug 24, 2026
Conversation
k-collie
requested changes
Aug 24, 2026
k-collie
left a comment
k-collie
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - I was getting this error (probably because I built in debug mode), this seems to have fixed it.
Could you add a requirement field while we're here?
k-collie
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run reference case within the restart test
tests. Currently, there is a potential race condition where the restart test depends on theheated_plate_convergecase having finished. While this has not caused an error yet to my knowledge, it certainly is possibleChecklist